HV-1459 HV-1460 Build improvements #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It generates a warning with the latest Maven version and is redundant with our enforcer configuration.
Member
|
Merged; thanks, @gsmet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gunnarmorling here are 2 small commits to clear a Maven warning when we launch a build with Maven 3.5.0 (maybe it did exist before but it's more visible with the colors) and integrate the sigtest testing in a profile.
Note that I did not include the sigtest directly in the build as I thought we might not want to execute it when working on new APIs and having the TCK lagging.
I'll create a CI job though once it's integrated so that we can be warned when there is an issue.